Rename DataSource and FileSource fields for consistency
#14898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
force-pushed
the
alamb/rename_properties
branch
from
c773b30 to
2834d58
Compare
alamb
commented
Feb 26, 2025
| /// Return the source object | ||
| pub fn source(&self) -> &Arc<dyn DataSource> { | ||
| &self.source | ||
| pub fn data_source(&self) -> &Arc<dyn DataSource> { |
There was a problem hiding this comment.
Here is the actual API change -- the rest of the PR is making local variable names consistent
berkaysynnada
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
46.0.0#14123DataSourceExecfor provided datasources, removeParquetExec,CsvExec, etc #14224Rationale for this change
While working on upgrading DataFusion 46 in several projects, I found the name
sourcesuper confusing as there are two similarly named traits,FileSourceandDataSourcebut several functions / fields are named justsourceso it is not clear which they refer toThis was especially confusing as
DataSourceExechas aDataSourcewhich is aFileScanConfignot theFileSOurce(which is a``ParquetSource` 🤯What changes are included in this PR?
data_sourceorfile_sourceto avoid the confusionThe documentation on how all these traits are related to each other is somewhat sparse. I am hoping to make a PR to improve it too
Are these changes tested?
By CI
Are there any user-facing changes?
While this is an API change, the releveant APIs were introduced in #14224 and thus not yet released, so I don't think this is explicitly a breaking change.