Migrate physical plan tests to insta (Part-2)
#15364
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @Shreyaskr1409 -- this looks really close. I left a few comments. Let me know what you think
FYI @blaginin
|
@alamb I updated everything. There are a few failing tests but they are failing due to time (lib) not getting compiled. This is unusual as tests passed the last time and I did not add any major changes which would make tests fail. Is there something more which I am supposed to do? |
I retriggered the test job and hopefully they will pass this time (sometimes there is some sort of intermittent issue 🤷 ) |
|
Passed on rerun. 🚀 |
|
Thanks again @Shreyaskr1409 and @xudong963 |
* Migrated tests to insta in aggregate/topk/heap.rs * Migrated tests to insta in joins/nested_loop_join.rs * Migrated tests to insta in joins/sort_merge_join.rs * Remove snapshot uploaded by mistake * Migrated tests to insta in repartition/mod.rs * Fix batches_to_sort_string problem and formatting
* Migrated tests to insta in aggregate/topk/heap.rs * Migrated tests to insta in joins/nested_loop_join.rs * Migrated tests to insta in joins/sort_merge_join.rs * Remove snapshot uploaded by mistake * Migrated tests to insta in repartition/mod.rs * Fix batches_to_sort_string problem and formatting
3 participants
Which issue does this PR close?
insta#15248.Rationale for this change
Completely migrate physical plan tests to
instaWhat changes are included in this PR?
Migrating from
assert_batches_sorted_eqandassert_batches_eqtoassert_snapshotin physical-plan testsAre these changes tested?
Yes, they are
Are there any user-facing changes?
No, they are not