ci: fix workflow triggering extended tests from pr comments. #15704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
|
how am I supposed to test this? |
|
Ok, here's what we're gonna do. I'll later push this fix to my |
ashdnazg
force-pushed
the
fix-extended-comment
branch
from
0fc1a29 to
8483746
Compare
For creating a workflow with workflow_dispatch, you can't specify a branch name in another repo as the ref. Instead you need to use the local ref to the PR.
ashdnazg
force-pushed
the
fix-extended-comment
branch
from
8483746 to
25ce537
Compare
|
Tested and looks to be working |
|
Given it is broken on main and this seems to work better, let's give it a try. Thank you @ashdnazg |
alamb
approved these changes
Apr 14, 2025
|
I tested it out on #15708 (comment) and it seems to be working well so far 👌 Thank you @ashdnazg |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
…15704) For creating a workflow with workflow_dispatch, you can't specify a branch name in another repo as the ref. Instead you need to use the local ref to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Triggering extended tests failed here: https://github.com/apache/datafusion/actions/runs/14439917392
For creating a workflow with workflow_dispatch, you can't specify a branch name in another repo as the ref.
Instead you need a local branch name and to send which PR to checkout as a parameter.
It sucks a bit that in the Actions list it looks like a test on
main, but I'm not sure there's a better alternative.Are these changes tested?
Here's the trigger working in ashdnazg#1 with the correct hash being used: https://github.com/ashdnazg/datafusion/actions/runs/14443854280/job/40499839662#step:2:3
Here's the test working as usual on push to main: https://github.com/ashdnazg/datafusion/actions/runs/14443836470/job/40499776589#step:2:2
Are there any user-facing changes?
No