Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 11, 2025

Which issue does this PR close?

  • Closes #.

Rationale for this change

I think adding some documentation would help a lot

What changes are included in this PR?

Add documentation and example to the function

Are these changes tested?

Yes by CI

Are there any user-facing changes?

More docs!

@github-actions github-actions bot added the common Related to common crate label Jun 11, 2025
Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the doc is very clear. 👍🏼

@alamb
Copy link
Contributor Author

alamb commented Jun 11, 2025

Thank you for the review @2010YOUY01

Copy link
Contributor

@gabotechs gabotechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice! I could really have use this info prior to Fix array_agg memory over use, thanks!

@xudong963 xudong963 merged commit 06ccae2 into apache:main Jun 11, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants