Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 12, 2025

Which issue does this PR close?

Rationale for this change

As @shehabgamin and I try and get more use / contributions of the datafusion-spark crate, having it more well documented will make that easier to do

What changes are included in this PR?

  1. Add a new page in the library user guide:
Screenshot 2025-06-12 at 12 03 53 AM Screenshot 2025-06-12 at 12 05 37 AM
  1. Add doc examples to the datafusion-spark crate:
Screenshot 2025-06-12 at 12 03 12 AM
  1. Activate the crypto-expressions feature needed to compile datafusion-spark outside the workspace

Are these changes tested?

Yes, it includes 2 new doc tests which are run as part of CI

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation core Core DataFusion crate spark labels Jun 12, 2025
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cc @andygrove

@comphead comphead merged commit 8e8c116 into apache:main Jun 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't publish datafusion-spark crate due to error [datafusion-spark] Example of using Spark compatible function library

4 participants