Fix Partial Sort Get Slice Point Between Batches #16881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Thank you @berkaysynnada -- I went over the PR carefully and I think it makes sense to me
The only thing I would also like to see is a SQL level test. However, I was not able to write one as I can't seem to get PartialSortExec to appear in the tests. I filed a ticket about this:
github-actions
bot
added
core
Can you check my last commit? I think it's what you want but I'm not sure about the location |
alamb
approved these changes
Jul 25, 2025
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* Update partial_sort.rs * Update partial_sort.rs * Update partial_sort.rs * add sql test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PartialSortExec had a missing functionality where it failed to detect slice points when consecutive batches contained homogeneous sort key values (e.g., first batch: all rows with a=1, second batch: all rows with a=2). The get_slice_point method only checked within individual batches, missing cross-batch transitions.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?