Derive UDWF equality from PartialEq, Hash #17057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ForeignWindowUDF` contains `FFI_WindowUDF` struct which was compared by pointer only. This means that effectively `ForeignWindowUDF` was also compared by pointer only, with all other equality checks being redundant. This commit simplifies the implementation to make it more obvious and more performant.
github-actions
bot
added
logical-expr
findepi
force-pushed
the
findepi/derive-udwf-equality-from-partialeq-hash-f01a0c
branch
from
8bc714d to
5b037a8
Compare
findepi
force-pushed
the
findepi/derive-udwf-equality-from-partialeq-hash-f01a0c
branch
from
5b037a8 to
edfff87
Compare
findepi
deleted the
findepi/derive-udwf-equality-from-partialeq-hash-f01a0c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce boilerplate in cases where implementation of
{ScalarUDFImpl,AggregateUDFImpl,WindowUDFImpl}::{equals,hash_value}can be derived using standardPartialEqandHashtraits.This is code complexity reduction. Follows #16842
While valuable on its own, this also prepares for more automatic derivation of UDF equals/hash and/or removal of default implementations (which currently are error-prone) -- #16677
WindowUDFImpl) equality from PartialEq, Hash #16867