Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 11, 2025

Which issue does this PR close?

Rationale for this change

@danila-b made a very cool set of github runner workflows to run the extended tests on demand on CI. The idea was that
it could be used to run the extended tests on each PR that might cause breakages before merging to main.

However, in practice it seems it is not used much and hasn't stopped regressions
as we had hoped. For example here are some recent issues that were closed that
mentioned extended tests
where extended tests broke after merging to main even
after the run extended tests command was added (on Mar 27, 2025):

I think the challenge is twofold:

  1. It is not obvious when to run the extended tests
  2. It is not obvious the result of the extended tests (it is reported as a Labeler check, which is not very visible -- see Add partial_sort.slt test for partially sorted data #16900 (comment) for an example)

I am sure we could the second point, but the first remains very hard.

Also, the complexity of the extended workflow makes it harder to understanding
and maintain and verify the security of the CI workflows in general.

Thus, I think it is best to remove the extended github comment workflow for now.

What changes are included in this PR?

  1. Remove the github extended workflow

Are these changes tested?

I tested it manually

Are there any user-facing changes?

Less PR automation

@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

run extended tests

@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

run extended tests

I don't expect this to do anything, but. want to verify that is the case

@alamb alamb marked this pull request as ready for review August 11, 2025 16:09
@alamb alamb changed the title Remove the "extended workflow" github action Remove the "run extended tests" github action Aug 11, 2025
@alamb alamb changed the title Remove the "run extended tests" github action Remove the "run extended tests" github PR commend action Aug 11, 2025
@alamb alamb added the development-process Related to development process of DataFusion label Aug 11, 2025
Copy link
Member

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Andrew. This seems reasonable to disable based on the discussion and the limited benefit it has shown.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

Here is another example of extended tests failing on main without us catching it

😢

@comphead
Copy link
Contributor

Here is another example of extended tests failing on main without us catching it

😢

WDYT if we enforce extended tests on RC branch-* branches?

@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

Here is another example of extended tests failing on main without us catching it

😢

WDYT if we enforce extended tests on RC branch-* branches?

Sounds good to me

@alamb alamb merged commit d375bfe into apache:main Aug 11, 2025
28 of 32 checks passed
@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

Thank you @timsaucer and @comphead

@alamb alamb deleted the alamb/remove_workflow branch August 11, 2025 18:52
@Omega359
Copy link
Contributor

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants