Cleanup to_char to avoid some clone
#17151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny time specifiers present.
This reverts commit b379fe1.
…e32-with-ts-format # Conflicts: # datafusion/functions/benches/to_char.rs
github-actions
bot
added
documentation
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
|
I don't really have time to finish this so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date32to string given timestamp specifiers #15361 is mergedWhich issue does this PR close?
Date32to string given timestamp specifiers #15361to_charfor array conversions #17152Rationale for this change
While reviewing the changes in
to_charI saw several potential improvementsDate32to string given timestamp specifiers #15361What changes are included in this PR?
This PR just avoids some clones, of Arcs which likely won't really improve performance noticably, but I ran out of time to do something more substantial. I will write up a ticket
Are these changes tested?
By existing CI
Are there any user-facing changes?