Fix: ListingTableFactory paths with dots #17233
Merged
+83
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue where files would not be detected when a path that represents a collection has a . in the final element of the prefix because the contents after the . would be interpreted as a file extension
github-actions
bot
added
core
xudong963
approved these changes
Aug 19, 2025
alamb
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ListingTableFactoryfails to read data when the final path element contains a.#17212What changes are included in this PR?
.in the final element of the prefix (e.g./path/to/versions/table.v1/) because the contents after the.would be interpreted as a file extensionAre these changes tested?
Yes, unit tests and
sqllogictests have been implemented to exercise these changesAre there any user-facing changes?
No
cc @alamb