avg(distinct) support for decimal types
#17560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and remove unused sum_distinct module
github-actions
bot
added
sqllogictest
Contributor
|
I'm also interested in improving decimal support, I have a PR that includes support for the new arrow types (decimal 32/64), this PR seems easier to merge first and then I'll rebase my PR to including this improved support. |
alamb
approved these changes
Sep 16, 2025
| self.target_precision, | ||
| self.target_scale, | ||
| )?; | ||
| // `distinct_count` returns `u64`, but `avg` expects `i256` |
Contributor
There was a problem hiding this comment.
I found this strange but after poking around I see there isn't a direct conversion from u64 --> i256:
let count: i256 = self.sum_accumulator.distinct_count().into();error[E0277]: the trait bound `arrow::datatypes::i256: std::convert::From<usize>` is not satisfied
--> datafusion/functions-aggregate-common/src/aggregate/avg_distinct/decimal.rs:105:73
|
105 | let count: i256 = self.sum_accumulator.distinct_count().into();
| ^^^^ the trait `std::convert::From<usize>` is not implemented for `arrow::datatypes::i256`
|
| fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<FieldRef>> { | ||
| if args.is_distinct { | ||
| // Copied from datafusion_functions_aggregate::sum::Sum::state_fields | ||
| // Decimal accumulator actually uses a different precision during accumulation, |
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Oct 2, 2025
* chore: mv `DistinctSumAccumulator` to common * feat: add avg distinct support for float64 type * chore: fmt * refactor: update import for DataType in Float64DistinctAvgAccumulator and remove unused sum_distinct module * feat: add avg distinct support for float64 type * feat: add avg distinct support for decimal * feat: more test for avg distinct in rust api * Remove DataFrame API tests for avg(distinct) * Remove proto test * Fix merge errors * Refactoring * Minor cleanup * Decimal slt tests for avg(distinct) * Fix state_fields for decimal distinct avg --------- Co-authored-by: YuNing Chen <[email protected]> Co-authored-by: Andrew Lamb <[email protected]> Co-authored-by: Dmitrii Blaginin <[email protected]>
alamb
added a commit
that referenced
this pull request
Oct 3, 2025
* chore: mv `DistinctSumAccumulator` to common * feat: add avg distinct support for float64 type * chore: fmt * refactor: update import for DataType in Float64DistinctAvgAccumulator and remove unused sum_distinct module * feat: add avg distinct support for float64 type * feat: add avg distinct support for decimal * feat: more test for avg distinct in rust api * Remove DataFrame API tests for avg(distinct) * Remove proto test * Fix merge errors * Refactoring * Minor cleanup * Decimal slt tests for avg(distinct) * Fix state_fields for decimal distinct avg --------- Co-authored-by: Jeffrey Vo <[email protected]> Co-authored-by: YuNing Chen <[email protected]> Co-authored-by: Andrew Lamb <[email protected]> Co-authored-by: Dmitrii Blaginin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
avg(distinct)support #2408Rationale for this change
This builds on top of the previous PR #15414 with some additional fixes. See previous PR for support on float types: #17255
What changes are included in this PR?
From original PR:
DecimalDistinctAvgAccumulatorimplementationAdditional changes made by me:
single_distinct_to_groupbydoesn't muddy the resultsstate_fieldsforAvgto account forDecimalDistinctAvgAccumulatorhaving a different data type compared to eventual return typeAre these changes tested?
Added slt tests.
Are there any user-facing changes?
No