-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Window::try_new_with_schema
with a descriptive error message
#17926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2543,16 +2543,22 @@ impl Window { | |||||||||||||||||
) | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
/// Create a new window function using the provided schema to avoid the overhead of | ||||||||||||||||||
/// building the schema again when the schema is already known. | ||||||||||||||||||
/// | ||||||||||||||||||
/// This method should only be called when you are absolutely sure that the schema being | ||||||||||||||||||
/// provided is correct for the window function. If in doubt, call [try_new](Self::try_new) instead. | ||||||||||||||||||
pub fn try_new_with_schema( | ||||||||||||||||||
window_expr: Vec<Expr>, | ||||||||||||||||||
input: Arc<LogicalPlan>, | ||||||||||||||||||
schema: DFSchemaRef, | ||||||||||||||||||
) -> Result<Self> { | ||||||||||||||||||
if window_expr.len() != schema.fields().len() - input.schema().fields().len() { | ||||||||||||||||||
let input_fields_count = input.schema().fields().len(); | ||||||||||||||||||
if schema.fields().len() != input_fields_count + window_expr.len() { | ||||||||||||||||||
return plan_err!( | ||||||||||||||||||
"Window has mismatch between number of expressions ({}) and number of fields in schema ({})", | ||||||||||||||||||
window_expr.len(), | ||||||||||||||||||
schema.fields().len() - input.schema().fields().len() | ||||||||||||||||||
"Window schema has wrong number of fields. Expected {} got {}", | ||||||||||||||||||
input_fields_count + window_expr.len(), | ||||||||||||||||||
schema.fields().len() | ||||||||||||||||||
Comment on lines
-2551
to
+2561
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I follow the error message from datafusion/datafusion/expr/src/logical_plan/plan.rs Lines 3470 to 3477 in 9e8ec54
|
||||||||||||||||||
); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reuse the docs from
Aggregate::try_new_with_schema
datafusion/datafusion/expr/src/logical_plan/plan.rs
Lines 3451 to 3456 in 9e8ec54