Precision::<usize>::{add, sub, multiply}: avoid overflows #17929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use saturating operations Note this is not consistent with Precision::<ScalarValue> that wraps, happy to change behavior to wrapping here too
Tpt
force-pushed
the
tpt/precision-overflow
branch
from
b51ddac to
7fba1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use saturating operations, if the operation saturates,
Exactis changed toInexactNote this is not consistent with
Precision::<ScalarValue>that wraps, happy to change behavior to wrapping here too if considered more relevant (but for cardinality estimations, saturation seems to make more sense to me).Which issue does this PR close?
Precision::multiplyoverflow #17928.Rationale for this change
Avoid panics on large number of joins in debug mode that explode estimated cardinalities.