Minor Test refactor: avoid creating the same SchemaRef #17951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 7, 2025
| Field::new("e", DataType::Boolean, true), | ||
| ])) | ||
| }); | ||
| Arc::clone(&SCHEMA) |
There was a problem hiding this comment.
Now each call to schema() clones an Arc rather than actually recreating the schema
timsaucer
approved these changes
Oct 7, 2025
|
Thanks @timsaucer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While working on an upgrade, I noticed the same schema was created by many distinct tests (and I am about to do it again).
Since the schema is always the same and is wrapped in an
Arcwe can just clone the ArcWhat changes are included in this PR?
Use a
static LazyLockto create the schema once and just pass out a reference to itAre these changes tested?
Yes by CI
Are there any user-facing changes?
No this is a test change only