Adds Instrumented Object Store to CLI #17984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the InstrumentedObjectStore to datafusion-cli to support building instrumented output for queries executed via the cli - Integrates the new InstrumentedObjectStore into the InstrumentedObjectStoreRegistry to ensure any ObjectStore instance registered gets instrumentation
BlakeOrth
force-pushed
the
feature/cli_instrumented_store
branch
from
90321ab to
e17a516
Compare
alamb
approved these changes
Oct 9, 2025
|
Thanks @BlakeOrth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This does not fully close, but is an incremental building block component for:
datafusion-cli] Add a way to see what object store requests are made #17207Functionally this code currently does nothing, but it's an important component that will allow instrumentation of object stores. The full context of how this code is likely to progress can be seen in the POC for this effort:
Rationale for this change
This is another bite-sized building block on the road to completing #17207
What changes are included in this PR?
Are these changes tested?
Yes. While no additional tests have been added, the
InstrumentedObjectStoreRegistrynow automatically invokes theInstrumentedObjectStorewhich means all new code is exercised under existing tests.Are there any user-facing changes?
No
cc @alamb