Change CacheAccessor::remove to take &self rather than &mut self
#18726
Conversation
Signed-off-by: Arpit Bandejiya <[email protected]>
|
@nuno-faria please take a look if this looks good! |
|
@nuno-faria please rerun the workflows! We can merge it post it hopefully :) |
|
@alchemist51 unfortunately I can't. @alamb could you please run the workflows? |
|
@alamb can you please review? |
|
Can you perhaps also add a brief mention in the https://datafusion.apache.org/library-user-guide/upgrading.html guide for 52? |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @nuno-faria and @alchemist51
alamb
changed the title
CacheAccessor::remove to take &self rather than &mut self
|
@alchemist51 would this chage also close #18362? |
@alamb can you please guide me to the repo/file? Will do that! |
https://github.com/apache/datafusion/blob/main/docs/source/library-user-guide/upgrading.md |
github-actions
bot
added
the
documentation
|
Updated, please check @alamb |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @nuno-faria and @alchemist51
Co-authored-by: Andrew Lamb <[email protected]>
|
Commited the suggestion, please merge it @alamb |
|
@alamb reminder for the merge! |
|
Thanks for the reminder @alchemist51 -- sorry I have been backed up getting the DataFusion and Arrow releases out |
apache#18726) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#18725 ## Rationale for this change The change make the cache accessor remove API interface inline with other APIs <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? Change the remove API for non mut type <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Covered in existing changes <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? The CacheAccessor trait will be slightly different now. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Signed-off-by: Arpit Bandejiya <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
3 participants
Which issue does this PR close?
Rationale for this change
The change make the cache accessor remove API interface inline with other APIs
What changes are included in this PR?
Change the remove API for non mut type
Are these changes tested?
Covered in existing changes
Are there any user-facing changes?
The CacheAccessor trait will be slightly different now.