feat: #215 resolve aliases for group by exprs #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @alamb |
Dandandan
reviewed
Jun 3, 2021
| select_exprs: &[Expr], | ||
| having_expr_opt: &Option<Expr>, | ||
| group_by: &[SQLExpr], | ||
| group_by_exprs: Vec<Expr>, |
Dandandan
reviewed
Jun 3, 2021
| format!("{:?}", err) | ||
| fn select_simple_aggregate_with_groupby_can_use_alias() { | ||
| quick_test( | ||
| "SELECT state AS a, MIN(age) AS b FROM person GROUP BY a", |
Contributor
|
Thank you for the contribution @jychen7 ! |
jychen7
changed the title
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
…#506) ## Which issue does this PR close? Closes apache#485 ## Rationale for this change Compatibility with how Spark handles logarithms of values <=0. ## What changes are included in this PR? Use IfExpr to check when input to log2 is <=0 and return null. This is done to match Spark's behavior, which in turn is implemented to match Hive's behavior. ## How are these changes tested? The existing test for `ln`, `log2` and `log10` was modified so that it includes negative numbers as part of the inputs being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #215 .
What changes are included in this PR?
support alias in group by expression
Are there any user-facing changes?
no