Modify tests for TPCH explain plans to avoid regressions #5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @jiangyinzuo @andygrove can you give this a look? |
jiangyinzuo
commented
Mar 25, 2023
| let plan = df.into_optimized_plan()?; | ||
| if !actual.is_empty() { | ||
| actual += "\n"; | ||
| if sql.starts_with("select") { |
Contributor
Author
There was a problem hiding this comment.
handle special query 15 which contains create view sql statement
jiangyinzuo
commented
Mar 26, 2023
| Ok(()) | ||
| } | ||
|
|
||
| fn create_context() -> Result<SessionContext> { |
Contributor
Author
There was a problem hiding this comment.
I fix the parameter target_partitions so that the generated plans are the same in different machines.
Dandandan
approved these changes
Mar 27, 2023
Contributor
|
Thank you @jiangyinzuo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1377.
Rationale for this change
I modify
async fn expected_plan()to utilizeEXPLAIN ...SQL statement to generate both logical and physical plans. There are only logical plans inbenchmarks/expected-plans/*.txtbefore this commit.What changes are included in this PR?
test output files in
benchmarks/expected-plans/*.txtandasync fn expected_plan()intpch.rsAre these changes tested?
yes
Are there any user-facing changes?
no