Skip to content

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Apr 30, 2023

Which issue does this PR close?

Closes -.

Rationale for this change

JIT based on cranelift is not really used since cranelift lacks the ability to inline rust functions, and yields inferior performance.

What changes are included in this PR?

Deprecate and remove the JIT module.

Are these changes tested?

Are there any user-facing changes?

@yjshen yjshen requested a review from alamb April 30, 2023 03:28
@github-actions github-actions bot added core Core DataFusion crate development-process Related to development process of DataFusion labels Apr 30, 2023
@yjshen yjshen requested review from alamb and tustvold and removed request for alamb and tustvold April 30, 2023 03:29
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yjshen ❤️

I am not sure what the word "deprecate" in the title of this PR means. Maybe we should simply say "remove JIT base don cranelift"?

@alamb alamb added the api change Changes the API exposed to users of the crate label Apr 30, 2023
@alamb alamb changed the title Deprecate and remove JIT based on cranelift Deprecate and remove JIT based on cranelift, and jit feature Apr 30, 2023
@yjshen yjshen changed the title Deprecate and remove JIT based on cranelift, and jit feature Remove JIT based on cranelift, and jit feature Apr 30, 2023
@yjshen yjshen merged commit d9d0a47 into apache:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate core Core DataFusion crate development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants