Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented May 3, 2023

Which issue does this PR close?

Noticed while reviewing #6196

Rationale for this change

These tests are for a function in another file

What changes are included in this PR?

Move the tests to be with the code they are testing

Are these changes tested?

only tests

Are there any user-facing changes?

no

@alamb alamb added the development-process Related to development process of DataFusion label May 3, 2023
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates and removed development-process Related to development process of DataFusion labels May 3, 2023
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alamb alamb merged commit 4297547 into apache:main May 4, 2023
@alamb alamb deleted the alamb/move_shift branch May 4, 2023 13:43
@alamb
Copy link
Contributor Author

alamb commented May 4, 2023

Thanks @viirya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants