Minor: make memory_limit tests more self describing #7190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
force-pushed
the
alamb/sort_test_cleanup
branch
from
8fc21b6 to
30c5254
Compare
alamb
changed the title
alamb
commented
Aug 18, 2023
| "select * from t order by host DESC", | ||
| vec
metesynnada
reviewed
Aug 18, 2023
Contributor
metesynnada
left a comment
metesynnada
left a comment
There was a problem hiding this comment.
LGTM, thanks for the effort.
Contributor
Author
|
Thank you for the review @metesynnada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5885
Rationale for this change
As DataFusion's memory limiting gets more sophisticated so do the tests for these limits. I made them better in #7131 and #7130 but they could be more self describing
What changes are included in this PR?
Complete switching memory_limit tests to builder style so each test reads more fluently and it is easier to understand what is going on
Are these changes tested?
Are there any user-facing changes?