feat: The "character_length" function handle "Binary" type #7350
Conversation
github-actions
bot
added
logical-expr
|
Thanks for working on this @parkma99. The fix works great ! |
| let args: Vec<ColumnarValue> = args | ||
| .iter() | ||
| .map(|col_value| { | ||
| cast_column(col_value, &DataType::Utf8, None).unwrap() |
There was a problem hiding this comment.
In there ,I do not know how to handle this unwrap.
|
Perhaps we could implement this as part of the coercion rules as opposed to internal to the evaluation logic? See coerce_arguments_for_fun perhaps? |
Thank you, it looks good, I will have a try lately |
I think it is a good solution. What do you think @tustvold ? |
|
Responded on the linked ticket |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you for working on this @parkma99 and @JayjeetAtGithub
Can we please add a .slt level test for this functionality?
I think there is a single coercion rule change (the same as https://github.com/apache/arrow-datafusion/pull/7365/files#r1303360870) that will fix this issue as well
4 participants
Which issue does this PR close?
Closes #7344
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?