Skip to content

Conversation

@Weijun-H
Copy link
Member

Which issue does this PR close?

Parts #7345

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Aug 24, 2023
@Weijun-H Weijun-H force-pushed the support-binary-for-min_max branch 2 times, most recently from edd63a5 to f2e4cc4 Compare August 25, 2023 01:02
@Weijun-H Weijun-H force-pushed the support-binary-for-min_max branch from f2e4cc4 to 11e7de6 Compare August 25, 2023 06:11
@Weijun-H Weijun-H marked this pull request as ready for review August 25, 2023 09:11
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Weijun-H -- this looks like a very nice improvement to me. I took the liberty of merging up from main to resolve the CI issue and I'll plan to merge this PR once the tests have passed.

@alamb alamb merged commit ba89505 into apache:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants