Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 24, 2023

Which issue does this PR close?

Closes #7398

Rationale for this change

A new version of clippy was released that is much pickier

What changes are included in this PR?

Fix new clippy lints (many via cargo clippy --fix)

Are these changes tested?

existing coverage

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate labels Aug 24, 2023
@alamb alamb marked this pull request as ready for review August 24, 2023 16:24
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like mostly is to remove vecs. Thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Aug 24, 2023

Thanks @viirya for the quick review. I plan to merge this PR once the CI passes to get the main branch passing CI again

@alamb alamb merged commit 3f8c512 into apache:main Aug 24, 2023
@alamb alamb deleted the alamb/clippy branch August 24, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Many clippy errors in Rust 1.72

2 participants