feat: Add memory pool configuration to datafusion-cli
#7424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Aug 26, 2023
datafusion-cli/src/main.rs
Outdated
| #[clap( | ||
| short = 'm', | ||
| long, | ||
| help = "The memory pool limitation (e.g. '10g'), default to 0", |
There was a problem hiding this comment.
Suggested change
| help = "The memory pool limitation (e.g. '10g'), default to 0", | |
| help = "The memory pool limitation (e.g. '10g'), default to None (no limit)", |
datafusion-cli/src/main.rs
Outdated
| let rn_config = | ||
| // set memory pool size | ||
| if let Some(memory_limit) = args.memory_limit { | ||
| let memory_limit = memory_limit[..memory_limit.len() - 1] |
There was a problem hiding this comment.
I think this simply passes 10 (bytes) along to the pool size when -m 10G is passed:
$ RUST_LOG=debug /Users/alamb/Software/target-df/debug/datafusion-cli -m 10g
DataFusion CLI v30.0.0
[2023-08-26T11:06:26Z DEBUG datafusion_execution::memory_pool::pool] Created new GreedyMemoryPool(pool_size=10)I think the pool size should work like this. What do you think?
-m 1000-- set pool size to 1000-m 500m-- set pool size to500 * 1024*1024(500 MB)-m 10G-- set pool size to10 * 1024*1024*1024(10 GB)
datafusion-cli/src/main.rs
Outdated
| help = "Specify the memory pool type 'greedy' or 'fair', default to 'greedy'", | ||
| validator(is_valid_memory_pool_type) | ||
| )] | ||
| mem_pool_type: Option<String>, |
There was a problem hiding this comment.
Another, perhaps more ideomatic way to do this, is to define an enum like
Suggested change
| mem_pool_type: Option<String>, | |
| mem_pool_type: Option<PoolType>, |
enum PoolType {
Greedy,
Fair
}
impl FromStr for PoolType {
...
}And then I think clap will do the right thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7419
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?