Skip to content

Conversation

@mapleFU
Copy link
Member

@mapleFU mapleFU commented Oct 3, 2023

Which issue does this PR close?

No issue, just a minor

Rationale for this change

Origin log is:

"skip page pruning due to lack of indexes. Have offset: {} file: {}",

I change it to:

"skip page pruning due to lack of indexes. Have offset: {}, column index: {}",

Other is fmt change.

What changes are included in this PR?

Change the log

Are these changes tested?

no

Are there any user-facing changes?

log wording change

@github-actions github-actions bot added the core Core DataFusion crate label Oct 3, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mapleFU

@mapleFU
Copy link
Member Author

mapleFU commented Oct 3, 2023

@mapleFU
Copy link
Member Author

mapleFU commented Oct 3, 2023

(oh seems I need to rebase the project)

@mapleFU
Copy link
Member Author

mapleFU commented Oct 3, 2023

Oh i think that's : #7733

@alamb
Copy link
Contributor

alamb commented Oct 3, 2023

I have merged #7733 so iif you rebase again the CI should pass. Thanks @mapleFU

@mapleFU
Copy link
Member Author

mapleFU commented Oct 3, 2023

I've rebase and update the description now.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @mapleFU and @Weijun-H

@alamb alamb merged commit a64f36d into apache:main Oct 3, 2023
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
)

* MINOR: change file to column index in page_filter trace log

* apply suggestion from review: add comma
@mapleFU mapleFU deleted the minor/change-file-in-trace-to-column-index branch October 30, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants