Skip to content

Conversation

@mustafasrepo
Copy link
Contributor

@mustafasrepo mustafasrepo commented Oct 6, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

With new version of RUST 1.73.0, some of the existing code doesn't pass from clippy. This PR resolves these linter errors.

What changes are included in this PR?

Are these changes tested?

Existing tests should work

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate labels Oct 6, 2023
@mustafasrepo mustafasrepo changed the title [MINOR]: Resolve linter errors [MINOR]: Resolve linter errors in the main Oct 6, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@mustafasrepo mustafasrepo merged commit 8504600 into apache:main Oct 6, 2023
@alamb
Copy link
Contributor

alamb commented Oct 6, 2023

Thank you @mustafasrepo and @ozankabak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants