refactor(7181): move streaming_merge() into separate mod from the merge node #7799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge mod. Merge mod has the SortPreservingMergeStream, containing the loser tree. This SortPreservingMergeStream struct will be used repeatedly as part of the cascading merge; in turn, the cascading merge will be implemented for the streaming_merge() method.
tustvold
approved these changes
Oct 12, 2023
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Prerequisite for the cascading merge.
Part of #7181 .
Rationale for this change
Create a new merge submodule which has the SortPreservingMergeStream (a.k.a. the loser tree). The SortPreservingMergeStream will be used repeatedly as part of the cascading merge tree.
By comparison, the streaming_merge() method will only be called once -- by the cascading struct (in the cascade submodule).
What changes are included in this PR?
See above.
Are these changes tested?
Only moving code. Nothing change.
Are there any user-facing changes?
No.