Minor: Document ExecutionPlan::equivalence_properties more thoroughly
#8128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
approved these changes
Nov 13, 2023
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
Thanks @alamb for documenting this. I will help implementers of new features a lot
viirya
reviewed
Nov 13, 2023
viirya
reviewed
Nov 13, 2023
viirya
reviewed
Nov 13, 2023
viirya
reviewed
Nov 13, 2023
viirya
approved these changes
Nov 13, 2023
Co-authored-by: Liang-Chi Hsieh <[email protected]> Co-authored-by: Mustafa Akur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8120
Rationale for this change
I did not properly set
ExecutionPlan::equivalence_propertiesfor one of our extension nodes, which took me a non trivial time to debug.What changes are included in this PR?
Add doc comments to
ExecutionPlan::equivalence_propertiesAre these changes tested?
By doc test
Are there any user-facing changes?