feat: support simplifying BinaryExpr with arbitrary guarantees in GuaranteeRewriter #8256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Thank you @wjones127
This simplification code is very nice, BTW. As we continue to work on improving statistics (like in #8078) seeing this code makes me even more strongly believe that using Intervals is the right approach (as it will fit in with this logic) vice nicely. cc @ozankabak
|
Agreed. BTW ee hope to send the improved interval library upstream by Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8255.
Rationale for this change
Mostly, I want to be able to simplify expressions involving nested column references.
What changes are included in this PR?
Are these changes tested?
Added one new test case for this.
Are there any user-facing changes?