Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 22, 2023

Which issue does this PR close?

N/A

Rationale for this change

While working with the file format code, I noticed that the parquet.rs module definition was in a different directory than its submodules which was confusing and not consistent with the rest of DataFusion's codebase

https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/src/datasource/physical_plan

Screenshot 2023-11-22 at 7 25 58 AM

What changes are included in this PR?

Move parquet to be with its submodules

Are these changes tested?

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review November 22, 2023 12:27
@github-actions github-actions bot added the core Core DataFusion crate label Nov 22, 2023
Copy link
Contributor

@korowa korowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @alamb

@alamb alamb merged commit a7cc089 into apache:main Nov 27, 2023
@alamb alamb deleted the alamb/better_mod branch November 27, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants