Skip to content

Conversation

@QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Nov 22, 2023

Which issue does this PR close?

Closes #8297

Rationale for this change

What changes are included in this PR?

refactor the format of output_orderings

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Nov 22, 2023
@QuenKar QuenKar changed the title refactor: output-ordering refactor: output ordering Nov 22, 2023
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QuenKar 👍

Co-authored-by: Alex Huang <[email protected]>
@QuenKar QuenKar requested a review from Weijun-H November 24, 2023 02:43
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @QuenKar 👍

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @QuenKar and @Weijun-H for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change output ordering display of sources

3 participants