Fix sqllogictests link in contributor-guide/index.md #8314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Nov 23, 2023
viirya
reviewed
Nov 23, 2023
There was a problem hiding this comment.
In How to add a new aggregate function section, there are two broken links too:
In [core/tests/sqllogictests/test_files](../../../datafusion/core/tests/sqllogictests/test_files), add new `sqllogictest` integration tests where the function is called through SQL against well known data and returns the expected result.
- Documentation for `sqllogictest` [here](../../../datafusion/core/tests/sqllogictests/README.md)
Could you fix it together in this PR?
|
Sure |
The crate was moved so the links need to be updated
|
I have also found an outdated link in sqllogictest/README.md |
|
Thank you @qrilka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
The crate was moved so the link needs to be updated
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
The new link shouldn't got to the "moved" document anymore.