Port tests in limit.rs to sqllogictest #8315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
8 tasks
alamb
approved these changes
Nov 28, 2023
| statement ok | ||
| CREATE TABLE t1000 (i BIGINT) AS | ||
| WITH t AS (VALUES (0), (0), (0), (0), (0), (0), (0), (0), (0), (0)) | ||
| SELECT ROW_NUMBER() OVER (PARTITION BY t1.column1) FROM t t1, t t2, t t3; |
There was a problem hiding this comment.
I double checked that this actually generates partitioned input and it does indeed.
You can see on my local setup that the MemoryExec has multiple partitions
❯ explain select distinct i from t1000;
+---------------+-----------------------------------------------------------------------------------------------------+
| plan_type | plan |
+---------------+-----------------------------------------------------------------------------------------------------+
| logical_plan | Aggregate: groupBy=[[t1000.i]], aggr=[[]] |
| | TableScan: t1000 projection=[i] |
| physical_plan | AggregateExec: mode=FinalPartitioned, gby=[i@0 as i], aggr=[] |
| | CoalesceBatchesExec: target_batch_size=8192 |
| | RepartitionExec: partitioning=Hash([i@0], 16), input_partitions=16 |
| | AggregateExec: mode=Partial, gby=[i@0 as i], aggr=[] |
| | MemoryExec: partitions=16, partition_sizes=[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 1] |
| | |
+---------------+-----------------------------------------------------------------------------------------------------+
There was a problem hiding this comment.
I took the liberty of updating some comments / adding an explain tests in 26510c9
|
Since I had it checked out anyways, I fixed the clippy issues in f5015ad and pushed to this branch |
|
Thank you very much @zhangxffff -- this is a great initial contribution. I really appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8204 .
SubTask of #6195 .