Skip to content

Conversation

@waynexia
Copy link
Member

@waynexia waynexia commented Dec 7, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Fix rust lints

What changes are included in this PR?

Two major warnings:

  • unnecessary try_from()
  • .get(0) to .first()

Are these changes tested?

Yes

Are there any user-facing changes?

No

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate labels Dec 7, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @waynexia -- this looks good to me

@waynexia waynexia merged commit c0c9e88 into apache:main Dec 8, 2023
@waynexia waynexia deleted the fix-clippy-2 branch December 8, 2023 02:23
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
* change get zero to first()

Signed-off-by: Ruihang Xia <[email protected]>

* wake clone to wake_by_ref

Signed-off-by: Ruihang Xia <[email protected]>

* more first()

Signed-off-by: Ruihang Xia <[email protected]>

* try_from() to from()

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants