Minor: reduce code duplication in date_bin_impl
#8528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Dec 13, 2023
| DataType::Timestamp(TimeUnit::Second, tz_opt) => { | ||
| let array = as_timestamp_second_array(array)? | ||
| ColumnarValue::Array(array) => { | ||
| fn process_array<T>( |
There was a problem hiding this comment.
can we name a function more precisely, process_array is too generic and requires the reader go to the functions internal code to figure what exactly it does
comphead
reviewed
Dec 13, 2023
| ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(f(*v), tz_opt.clone())) | ||
| } | ||
| ColumnarValue::Scalar(ScalarValue::TimestampMicrosecond(v, tz_opt)) => { | ||
| let f = stride_map_fn::<TimestampMicrosecondType>(origin, stride, stride_fn); |
There was a problem hiding this comment.
please rename f to more precise name, like apply_stride, etc
comphead
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?