Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 15, 2023

Which issue does this PR close?

Minor follow on to #8501 from @razeghi71

Rationale

I think the test added in #8501 would be easier to find if they were in the existing map.slt file

What changes are included in this PR?

  1. Move test with map array to map.slt

Are these changes tested?

only tests

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review December 15, 2023 00:30
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 15, 2023
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb
btw what do you think about adding a mandatory description on the test query and eventually output it?

@alamb
Copy link
Contributor Author

alamb commented Dec 20, 2023

lgtm thanks @alamb btw what do you think about adding a mandatory description on the test query and eventually output it?

Thanks @comphead -- I am not quite sure what you mean

Do you mean require a comment on each query that explains what is expected? It sounds reasonable to me, though if we aren't careful we'll end up with comments like # ensure correct output which probably don't add much value

@comphead
Copy link
Contributor

lgtm thanks @alamb btw what do you think about adding a mandatory description on the test query and eventually output it?

Thanks @comphead -- I am not quite sure what you mean

Do you mean require a comment on each query that explains what is expected? It sounds reasonable to me, though if we aren't careful we'll end up with comments like # ensure correct output which probably don't add much value

composing a correct description can be part of review.

@alamb
Copy link
Contributor Author

alamb commented Dec 20, 2023

composing a correct description can be part of review.

I agree this would be great. I am just wondering how to make it happen -- if the review requires human intervention anyways, I am not sure automation will help 🤔

@alamb alamb merged commit 778779f into apache:main Dec 20, 2023
@alamb alamb deleted the alamb/move_map_test branch December 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants