Skip to content

Conversation

@guojidan
Copy link
Contributor

@guojidan guojidan commented Jan 4, 2024

Which issue does this PR close?

Closes #8734 .

Rationale for this change

Clean internal implementation of WindowUDF to use WindowUDFImpl

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Jan 4, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection @guojidan -- thank you very much for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean internal implementation of WindowUDF to use WindowUDFImpl (rather than the function pointers)

2 participants