Minor: clarify performance in docs for ScalarUDF, ScalarUDAF and ScalarUDWF
#9384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
comphead
approved these changes
Feb 28, 2024
jayzhan211
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #8578
Rationale for this change
@SteveLauC asked about why the "simple" APIs were less performant https://github.com/apache/arrow-datafusion/pull/8578/files#r1505483541
In researching the answer I concluded that they are not really less performant, and thus the documentation shouldn't imply they are.
What changes are included in this PR?
Update the docs to explain the difference better
Are these changes tested?
CI docs test
Are there any user-facing changes?