Enable configurable display of partition sizes in the explain statement #9474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
core
jayzhan211
changed the title
jayzhan211
changed the title
jayzhan211
commented
Mar 6, 2024
| Self::try_new_with_show_sizes(partitions, schema, projection, true) | ||
| } | ||
|
|
||
| pub fn try_new_with_show_sizes( |
Contributor
Author
There was a problem hiding this comment.
create a new function to avoid changing too many existing try new functions
Contributor
There was a problem hiding this comment.
I think, instead of this API. You can use builder API such as below
pub fn with_show_sizes(mut self, show_sizes: bool) -> Self{
self.show_sizes = show_sizes;
}However, this is purely stylistic. Feel free to proceed as you wish.
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
changed the title
jayzhan211
changed the title
mustafasrepo
approved these changes
Mar 6, 2024
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
Left some minor comment. Other than this, this PR is LGTM!. Thanks @jayzhan211
Signed-off-by: jayzhan211 <[email protected]>
Contributor
|
Thank you so much @jayzhan211 and @mustafasrepo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9450.
There might be others MemExec::try_new that need to be replaced with try_new_show_sizes, but I only changed the necessary one to fix the limit.slt for now.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?