-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17857][e2e] Fix Kubernetes and docker e2e tests on Mac OS #12451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17857][e2e] Fix Kubernetes and docker e2e tests on Mac OS #12451
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4c93b68 (Wed Jun 03 02:36:43 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
rmetzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. The change looks good to me.
I'm +1 on merging this once CI has passed. I believe a quick check by @zentol would be good as well.
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it didn't break CI and I can't verify the correctness on MacOS; there's not much more input I can provide.
|
If FLINK-18121 could be done soon, then we could use the local flink-dist to build the image. It is more straightforward and easier. |
|
Damn. I forgot to merge this, sorry. I've rebased it myself. Once CI has passed (again), I'll merge it. |
|
Sorry for the late response. Since the code in master has changes after this PR is approved, I am afraid it still could not work on Mac OS. @rmetzger I will create another following PR to address the issues. |
What is the purpose of the change
In FLINK-17656, we migrate all the e2e tests from flink-container/docker to apache/flink-docker. After the migration, when building a docker image, we need to start a file server and then download it in the Dockerfile.
It works well in linux environment since the minikube is started in "vm-driver=none". However, it is not true in the Mac. We usually start a virtual machine for minikube and this will make "localhost" could not work.
The same case also exists for docker tests. Because "localhost" is not be accessible when building the image even we set the --network=host
Brief change log
Verifying this change
The following tests could run successfully on Mac OS
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation