Skip to content

Conversation

@wangyang0918
Copy link
Contributor

What is the purpose of the change

In FLINK-17656, we migrate all the e2e tests from flink-container/docker to apache/flink-docker. After the migration, when building a docker image, we need to start a file server and then download it in the Dockerfile.

It works well in linux environment since the minikube is started in "vm-driver=none". However, it is not true in the Mac. We usually start a virtual machine for minikube and this will make "localhost" could not work.

The same case also exists for docker tests. Because "localhost" is not be accessible when building the image even we set the --network=host

Brief change log

  • Fix K8s e2e tests
  • Fix docker e2e tests

Verifying this change

The following tests could run successfully on Mac OS

  • test_kubernetes_embedded_job.sh
  • test_kubernetes_session.sh
  • test_kubernetes_application.sh
  • test_docker_embedded_job.sh

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4c93b68 (Wed Jun 03 02:36:43 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. The change looks good to me.
I'm +1 on merging this once CI has passed. I believe a quick check by @zentol would be good as well.

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it didn't break CI and I can't verify the correctness on MacOS; there's not much more input I can provide.

@wangyang0918
Copy link
Contributor Author

If FLINK-18121 could be done soon, then we could use the local flink-dist to build the image. It is more straightforward and easier.

@rmetzger
Copy link
Contributor

rmetzger commented Oct 9, 2020

Damn. I forgot to merge this, sorry. I've rebased it myself. Once CI has passed (again), I'll merge it.

@rmetzger rmetzger closed this in 232b61f Oct 13, 2020
@wangyang0918
Copy link
Contributor Author

Sorry for the late response.

Since the code in master has changes after this PR is approved, I am afraid it still could not work on Mac OS. @rmetzger I will create another following PR to address the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants