Skip to content

[hotfix] Do not use ExecutorService.submit since it can swallow exceptions #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[hotfix] Do not use ExecutorService.submit since it can swallow exceptions #15740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...c/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public class KubernetesLeaderElector {
@VisibleForTesting
public static final String LEADER_ANNOTATION_KEY = "control-plane.alpha.kubernetes.io/leader";

private final Object lock = new Object();

private final ExecutorService executorService =
Executors.newSingleThreadExecutor(
new ExecutorThreadFactory("KubernetesLeaderElector-ExecutorService"));
Expand Down Expand Up @@ -92,11 +94,20 @@ public KubernetesLeaderElector(
}

public void run() {
executorService.submit(internalLeaderElector::run);
synchronized (lock) {
if (executorService.isShutdown()) {
LOG.debug(
"Ignoring KubernetesLeaderElector.run call because the leader elector has already been shut down.");
} else {
executorService.execute(internalLeaderElector::run);
}
}
}

public void stop() {
executorService.shutdownNow();
synchronized (lock) {
executorService.shutdownNow();
}
}

public static boolean hasLeadership(KubernetesConfigMap configMap, String lockIdentity) {
Expand Down