7.0.x Bug - Don't call a resource constructor until GORM has been initialized by Spring

[codeconsole]

The Problem

Caused by: java.lang.IllegalStateException: org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@48300ca8 has not been refreshed yet
        at org.springframework.context.support.AbstractApplicationContext.assertBeanFactoryActive(AbstractApplicationContext.java:1262)
        at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1280)
        at org.grails.web.context.ServletEnvironmentGrailsApplicationDiscoveryStrategy.findGrailsApplication(ServletEnvironmentGrailsApplicationDiscoveryStrategy.groovy:54)
        at grails.util.Holders.findApplication(Holders.java:126)
        at org.grails.plugins.web.controllers.api.ControllersDomainBindingApi.autowire(ControllersDomainBindingApi.java:90)
        at org.grails.plugins.web.controllers.api.ControllersDomainBindingApi.initialize(ControllersDomainBindingApi.java:50)
        at com.pixoto.community.CategoryParticipant.<init>(CategoryParticipant.groovy)
        at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
        ... 43 common frames omitted

This is only an issue during a Spring Dev Tools restart, but this fixes the issue.

  this.resource = resource.getDeclaredConstructor().newInstance() as GormAllOperations<T>

results in a domain object instantiation during the constructor, which:

1. Triggers Grails GORM enhancements
2. Calls ControllersDomainBindingApi.initialize()
3. Tries to access Holders.findApplication()
4. Fails during DevTools restart when ApplicationContext is being switched

The Fix

Lazy initialize the resource

[codeconsole]

@matrei if you recall, we did this this.resource = resource.getDeclaredConstructor().newInstance() as GormAllOperations<T> so we could @CompileStatic

but I think it is best to keep resource a Class<T> for 2 reasons:

1. Simplify the DomainServiceLocator lookup
2. Keep in line with

   grails-core/grails-rest-transforms/src/main/groovy/grails/rest/RestfulController.groovy

   Lines 46 to 47 in 7f9a2c0

   	Class<T> resource
   	String resourceName

Also, I found it unnecessary to instantiate an instance if we separate GormAllOperations<T> and Class<T>

[jdaugherty]

This field is now private, while it was public before. This is a breaking change for a non-major release ...

[codeconsole]

@jdaugherty this is something that is not documented that nobody uses, but I have no problem removing private. done.

[matrei]

From what I can tell, there was no gormStaticApi property before this change, so it should be private as it is lazily instantiated in the getter.

However, the resource property has changed type, which is breaking.

[jdaugherty]

Is there a reason we renamed the field?

[codeconsole]

but I think it is best to keep resource a Class for 2 reasons:

@matrei @jdaugherty I explained my rational for the name change in the comment above

[matrei]

From what I can tell, there was no gormStaticApi property before this change, so it should be private as it is lazily instantiated in the getter.

However, the resource property has changed type, which is breaking.