HDDS-1766. ContainerStateMachine is unable to increment lastAppliedTermIndex. Contributed by Mukul Kumar Singh. #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmIndex. Contributed by Mukul Kumar Singh.
Contributor
|
Looks good. Pending test results. |
lokeshj1703
reviewed
Jul 10, 2019
| } | ||
|
|
||
| private void updateLastApplied() { | ||
| private synchronized void updateLastApplied() { |
Contributor
There was a problem hiding this comment.
@mukul1987 Thanks for working on this! The patch looks good to me.
I think we can avoid using synchronized by using a concurrent sorted map. Each applyTransaction removes its corresponding entry from the map and we update lastApplied based on the first entry in the map?
Contributor
Author
There was a problem hiding this comment.
HDDS-1792 will fix this by using ConcurrentHashSet.
Contributor
|
@mukul1987 The changes look good to me. +1. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
SAMZA-2228:added LICENCE and NOTICE to samza-tools
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…rmIndex. Contributed by Mukul Kumar Singh. (apache#1072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last applied term index wasn't updated as the method is called by multiple executors and the method was not synchronized.