HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. #1219

bharatviswa504 · 2019-08-02T23:00:35Z

No description provided.

hadoop-yetus · 2019-08-06T08:31:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	120	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	82	Maven dependency ordering for branch
+1	mvninstall	641	trunk passed
+1	compile	385	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	967	branch has no errors when building and testing our client artifacts.
+1	javadoc	173	trunk passed
0	spotbugs	474	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	682	trunk passed
		_ Patch Compile Tests _
0	mvndep	33	Maven dependency ordering for patch
+1	mvninstall	579	the patch passed
+1	compile	383	the patch passed
+1	javac	383	the patch passed
+1	checkstyle	80	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	739	patch has no errors when building and testing our client artifacts.
+1	javadoc	165	the patch passed
+1	findbugs	696	the patch passed
		_ Other Tests _
+1	unit	342	hadoop-hdds in the patch passed.
-1	unit	2476	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		8846

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/5/artifact/out/Dockerfile
GITHUB PR	#1219
Optional Tests	dupname asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle
uname	Linux 9e6c57b09982 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `1127215`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/5/testReport/
Max. process+thread count	5206 (vs. ulimit of 5500)
modules	C: hadoop-hdds/docs hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-06T08:38:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	135	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	100	Maven dependency ordering for branch
+1	mvninstall	697	trunk passed
+1	compile	382	trunk passed
+1	checkstyle	79	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	990	branch has no errors when building and testing our client artifacts.
+1	javadoc	171	trunk passed
0	spotbugs	494	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	700	trunk passed
		_ Patch Compile Tests _
0	mvndep	32	Maven dependency ordering for patch
+1	mvninstall	609	the patch passed
+1	compile	452	the patch passed
+1	javac	452	the patch passed
+1	checkstyle	76	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	761	patch has no errors when building and testing our client artifacts.
+1	javadoc	203	the patch passed
+1	findbugs	736	the patch passed
		_ Other Tests _
+1	unit	357	hadoop-hdds in the patch passed.
-1	unit	2644	hadoop-ozone in the patch failed.
+1	asflicense	56	The patch does not generate ASF License warnings.
		9362

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/4/artifact/out/Dockerfile
GITHUB PR	#1219
Optional Tests	dupname asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle
uname	Linux 2ad3184e1498 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `1127215`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/4/testReport/
Max. process+thread count	4130 (vs. ulimit of 5500)
modules	C: hadoop-hdds/docs hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao · 2019-08-06T21:00:24Z

hadoop-hdds/docs/content/shell/BucketCommands.md

  * [delete](#delete)
  * [info](#info)
  * [list](#list)
-  * [update](#update)


Should we block the acl update part of BucketManagerImpl#setBucketProperty() as they now require a different permission (WRITE_ACL instead of WRITE)? I see there are few UT assumes setBucketProperty should be able to change acl without differentiation. We can fix his in follow up JIRA and use the current one just to remove the CLI.

Ya sure @xiaoyuyao.
I will open a new Jira to address this too.
We can let this change in to fix only remove CLI part.

https://issues.apache.org/jira/browse/HDDS-1913
Will address this and also fixing Bucket and RpcClient API's.

Ping @xiaoyuyao for review.

LGTM. +1. Let's fix the remaining issues in HDDS-1913.

bharatviswa504 · 2019-08-08T00:07:14Z

Test failures are not related to this patch.
I will commit this to the trunk and ozone-0.4.1
Thank You @xiaoyuyao for the review.

…#1219) (cherry picked from commit 70b4617)

hadoop-yetus · 2019-08-08T02:38:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	169	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	112	Maven dependency ordering for branch
+1	mvninstall	813	trunk passed
+1	compile	491	trunk passed
+1	checkstyle	92	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1108	branch has no errors when building and testing our client artifacts.
+1	javadoc	217	trunk passed
0	spotbugs	568	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	850	trunk passed
		_ Patch Compile Tests _
0	mvndep	74	Maven dependency ordering for patch
+1	mvninstall	663	the patch passed
+1	compile	425	the patch passed
+1	javac	425	the patch passed
+1	checkstyle	99	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	839	patch has no errors when building and testing our client artifacts.
+1	javadoc	204	the patch passed
+1	findbugs	774	the patch passed
		_ Other Tests _
+1	unit	406	hadoop-hdds in the patch passed.
-1	unit	2269	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		9839

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/6/artifact/out/Dockerfile
GITHUB PR	#1219
Optional Tests	dupname asflicense mvnsite compile javac javadoc mvninstall unit shadedclient findbugs checkstyle
uname	Linux c69bf2636810 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3cc0ace`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/6/testReport/
Max. process+thread count	4257 (vs. ulimit of 5500)
modules	C: hadoop-hdds/docs hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1219/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…apache#1219)

bharatviswa504 requested a review from xiaoyuyao August 2, 2019 23:00

bharatviswa504 added the ozone label Aug 2, 2019

bharatviswa504 self-assigned this Aug 2, 2019

bharatviswa504 added 3 commits August 5, 2019 19:22

HDDS-1900. Remove UpdateBucket handler.

5a37d12

revert correct test.

26968c8

fix acceptance checkstyle and doc.

f90c794

bharatviswa504 force-pushed the HDDS-1900 branch 2 times, most recently from f90c794 to 338776d Compare August 6, 2019 06:01

apache deleted a comment from hadoop-yetus Aug 6, 2019

bharatviswa504 force-pushed the HDDS-1900 branch from 338776d to f90c794 Compare August 6, 2019 06:02

xiaoyuyao reviewed Aug 6, 2019

View reviewed changes

xiaoyuyao approved these changes Aug 7, 2019

View reviewed changes

bharatviswa504 merged commit 70b4617 into apache:trunk Aug 8, 2019

asfgit pushed a commit that referenced this pull request Aug 8, 2019

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. (…

b813c14

…#1219) (cherry picked from commit 70b4617)

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. (…

71bfdb2

…apache#1219)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. #1219

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. #1219

Uh oh!

bharatviswa504 commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 6, 2019

Uh oh!

hadoop-yetus commented Aug 6, 2019

Uh oh!

xiaoyuyao Aug 6, 2019

Uh oh!

bharatviswa504 Aug 6, 2019

Uh oh!

bharatviswa504 Aug 7, 2019

Uh oh!

bharatviswa504 Aug 7, 2019

Uh oh!

xiaoyuyao Aug 7, 2019

Uh oh!

bharatviswa504 commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. #1219

HDDS-1900. Remove UpdateBucket handler which supports add/remove Acl. #1219

Uh oh!

Conversation

bharatviswa504 commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 6, 2019

Uh oh!

hadoop-yetus commented Aug 6, 2019

Uh oh!

xiaoyuyao Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyao Aug 7, 2019

Choose a reason for hiding this comment

Uh oh!

bharatviswa504 commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants