HDFS-15478: When Empty mount points, we are assigning fallback link to self. But it should not use full URI for target fs. #2160

umamaheswararao · 2020-07-20T23:59:36Z

https://issues.apache.org/jira/browse/HDFS-15478

…o self. But it should not use full URI for target fs.

hadoop-yetus · 2020-07-21T02:44:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 54s	trunk passed
+1 💚	compile	21m 2s	trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	compile	17m 47s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 45s	trunk passed
+1 💚	mvnsite	1m 24s	trunk passed
+1 💚	shadedclient	17m 58s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 36s	hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	0m 54s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 14s	Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	2m 12s	hadoop-common-project/hadoop-common in trunk has 2 extant findbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	20m 24s	the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	javac	20m 24s	the patch passed
+1 💚	compile	19m 25s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	19m 25s	the patch passed
+1 💚	checkstyle	0m 45s	the patch passed
+1 💚	mvnsite	1m 25s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	17m 6s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 42s	hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 7s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 21s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		163m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/artifact/out/Dockerfile
GITHUB PR	#2160
JIRA Issue	HDFS-15478
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9e79b4bff7dd 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3833c61`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/testReport/
Max. process+thread count	2322 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn · 2020-07-21T13:18:04Z

Thanx @umamaheswararao for the work here. The changes LGTM.
Can we update this behavior in ViewFsOverloadScheme.md as well?

umamaheswararao · 2020-07-21T22:16:46Z

Thanks for the review @ayushtkn. Updated the doc.

ayushtkn

Thanx @umamaheswararao for the update.
+1

hadoop-yetus · 2020-07-22T03:42:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	markdownlint	0m 1s	markdownlint was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	27m 7s	trunk passed
+1 💚	compile	28m 55s	trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	compile	23m 55s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	3m 30s	trunk passed
+1 💚	mvnsite	3m 53s	trunk passed
+1 💚	shadedclient	25m 4s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 38s	hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌	javadoc	0m 43s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 41s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	2m 12s	hadoop-common-project/hadoop-common in trunk has 2 extant findbugs warnings.
-1 ❌	findbugs	3m 13s	hadoop-hdfs-project/hadoop-hdfs in trunk has 4 extant findbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 53s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	20m 10s	the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚	javac	20m 10s	the patch passed
+1 💚	compile	17m 39s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	17m 39s	the patch passed
+1 💚	checkstyle	2m 50s	the patch passed
+1 💚	mvnsite	2m 44s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 27s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 36s	hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌	javadoc	0m 41s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚	javadoc	1m 40s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	5m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 24s	hadoop-common in the patch passed.
-1 ❌	unit	121m 34s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 22s	The patch does not generate ASF License warnings.
		324m 55s

Reason	Tests
Failed junit tests	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestGetFileChecksum
	hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/Dockerfile
GITHUB PR	#2160
JIRA Issue	HDFS-15478
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname	Linux 638a11bc8c16 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d23cc9d`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/testReport/
Max. process+thread count	2682 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2160/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…o self. But it should not use full URI for target fs. (#2160). Contributed by Uma Maheswara Rao G. (cherry picked from commit ac9a07b)

…o self. But it should not use full URI for target fs. (apache#2160). Contributed by Uma Maheswara Rao G. (cherry picked from commit ac9a07b) Change-Id: I36efce0db70f8c60211ccfc3ece3b16414a8f267 (cherry picked from commit dfcffc1)

HDFS-15478: When Empty mount points, we are assigning fallback link t…

de7178c

…o self. But it should not use full URI for target fs.

umamaheswararao requested a review from ayushtkn July 21, 2020 10:27

doc update

c9bacae

ayushtkn approved these changes Jul 22, 2020

View reviewed changes

umamaheswararao merged commit ac9a07b into apache:trunk Jul 22, 2020

umamaheswararao deleted the HDFS-15478 branch July 22, 2020 06:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15478: When Empty mount points, we are assigning fallback link to self. But it should not use full URI for target fs. #2160

HDFS-15478: When Empty mount points, we are assigning fallback link to self. But it should not use full URI for target fs. #2160

Uh oh!

umamaheswararao commented Jul 20, 2020

Uh oh!

hadoop-yetus commented Jul 21, 2020

Uh oh!

ayushtkn commented Jul 21, 2020

Uh oh!

umamaheswararao commented Jul 21, 2020

Uh oh!

ayushtkn left a comment

Uh oh!

hadoop-yetus commented Jul 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-15478: When Empty mount points, we are assigning fallback link to self. But it should not use full URI for target fs. #2160

HDFS-15478: When Empty mount points, we are assigning fallback link to self. But it should not use full URI for target fs. #2160

Uh oh!

Conversation

umamaheswararao commented Jul 20, 2020

Uh oh!

hadoop-yetus commented Jul 21, 2020

Uh oh!

ayushtkn commented Jul 21, 2020

Uh oh!

umamaheswararao commented Jul 21, 2020

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants