-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16007. Deserialization of ReplicaState should avoid throwing ArrayIndexOutOfBoundsException #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
9b3036e to
062e842
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer Validate#validIndex in commons-lang3 rather than Guava. We should avoid guava as possible.
Sure, let me make this change right away. |
…ayIndexOutOfBoundsException
062e842 to
5014857
Compare
aajisaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Jenkins.
|
💔 -1 overall
This message was automatically generated. |
|
Thanks for the review @aajisaka. All test failures seem flakies. |
|
@aajisaka sorry to bother you again. If you are fine with QA result, could you please help merge this PR and branch-3.3 backport? |
|
Merged. Thank you @virajjasani |
…ayIndexOutOfBoundsException (#2982) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit b944084)
…ayIndexOutOfBoundsException (apache#2982) Signed-off-by: Akira Ajisaka <[email protected]>
HDFS-16007