HADOOP-17979. Add Interface EtagSource to allow FileStatus subclasses to provide etags #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
new tests happy; regression tests in progress. note this also moves abfs listFiles and listLocatedStatus API calls into being incremental. this is a good thing anyway |
steveloughran
force-pushed
the
abfs/HADOOP-17979-etag-api
branch
from
ce3b5d4 to
56daef7
Compare
Contributor
Author
|
tested: azure cardiff. all good except failures addressed in #3641 |
Contributor
mukund-thakur
left a comment
mukund-thakur
left a comment
There was a problem hiding this comment.
Looks good. Just let's wait for the Yetus to have a proper run.
Contributor
Author
|
yetus is done. it's complaining about deprecation, but the deprecated method is only used in the s3a code in s3guard classes cut in another PR. I'm not going to fix them because it will only create merge conflict. |
mehakmeet
approved these changes
Nov 17, 2021
Contributor
mehakmeet
left a comment
mehakmeet
left a comment
There was a problem hiding this comment.
+1. Prod code is all good, just some small nits in test.
...ject/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractEtagTest.java
Outdated
Show resolved
Hide resolved
...ject/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractEtagTest.java
Outdated
Show resolved
Hide resolved
...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
Outdated
Show resolved
Hide resolved
mukund-thakur
approved these changes
Nov 22, 2021
Contributor
mukund-thakur
left a comment
mukund-thakur
left a comment
There was a problem hiding this comment.
LGTM +1, Pending yetus failure.
steveloughran
force-pushed
the
abfs/HADOOP-17979-etag-api
branch
from
fac1a2e to
662471a
Compare
Contributor
Author
|
ok, just pushed up a rebase with the checkstyle fix |
steveloughran
force-pushed
the
abfs/HADOOP-17979-etag-api
branch
from
662471a to
8d4c331
Compare
* Pull out from HADOOP-17981/apache#3611 * Add S3A support * Add requirement that located status API calls MUST also support the API, and do this for ABFS. s3a code retains now deprecated getETag entries. lots of references in the s3guard code which I am leaving alone. Change-Id: I16c10c73873b3cbe60433adb9bbc7c1441221dbb
* style, spotbugs and EOL. not done -move off deprecated S3AStatus.getETag() call in S3Guard production/test code. The big patch to delete that will remove all those classes, changing it here only creates merge problems. Change-Id: Ia054465d43022c7fc38ae9afb762b66fbd1c8f55
Change-Id: If30dd4c6f5d6d9f868488c512aec2cbe41a6fe26
Change-Id: I33dae40b2ead002e2ef63983e0263417bf0c3f47
Change-Id: Ibe8140e75901cf18870cf2377f38dc6066ee516d
Change-Id: I35eb4686ae1b418814955635b8acf5480bd9d0cd
steveloughran
force-pushed
the
abfs/HADOOP-17979-etag-api
branch
from
8d4c331 to
3c7821a
Compare
steveloughran
force-pushed
the
abfs/HADOOP-17979-etag-api
branch
from
3c7821a to
a83da40
Compare
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2021
… to provide etags (#3633) Contributed by Steve Loughran Change-Id: I596205d788f623114c12962941445432e2036c34
sunchao
pushed a commit
that referenced
this pull request
Jan 4, 2022
… to provide etags (#3633) Contributed by Steve Loughran Change-Id: I596205d788f623114c12962941445432e2036c34
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… to provide etags (apache#3633) Contributed by Steve Loughran
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and do this for ABFS.
s3a code retains now deprecated getETag entries. lots of references in
the s3guard code which I am leaving alone.
How was this patch tested?
new integration tests for abfs and s3a
For code changes: