HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4896

hotcodemacha · 2022-09-16T08:03:13Z

Description of PR

LocalDirAllocator to provide diagnostics when file creation fails.

Cherrr-picking - 0f03299

JIRA - HADOOP-16769

How was this patch tested?

UT

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…tion fails (apache#4842) The patch provides detailed diagnostics of file creation failure in LocalDirAllocator. Contributed by: Ashutosh Gupta

hotcodemacha · 2022-09-16T08:04:08Z

@mehakmeet - Cherry-picked 0f03299 for branch-3.3. Please help in review/merge. Thanks.

hadoop-yetus · 2022-09-16T10:58:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	39m 35s		branch-3.3 passed
+1 💚	compile	23m 48s		branch-3.3 passed
+1 💚	checkstyle	1m 24s		branch-3.3 passed
+1 💚	mvnsite	2m 19s		branch-3.3 passed
+1 💚	javadoc	1m 22s		branch-3.3 passed
+1 💚	spotbugs	3m 15s		branch-3.3 passed
+1 💚	shadedclient	29m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 2s		the patch passed
+1 💚	compile	18m 19s		the patch passed
+1 💚	javac	18m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 44s		the patch passed
+1 💚	javadoc	0m 54s		the patch passed
+1 💚	spotbugs	2m 51s		the patch passed
+1 💚	shadedclient	28m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 41s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 8s		The patch does not generate ASF License warnings.
		174m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/1/artifact/out/Dockerfile
GITHUB PR	#4896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 2542f7cd7522 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `dc33468`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/1/testReport/
Max. process+thread count	1253 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hotcodemacha · 2022-09-20T05:20:40Z

Hi @mehakmeet. Please help in reviewing/merging this cherry-pick and closing the JIRA. Thanks.

hadoop-yetus · 2022-09-20T08:49:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	10m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	40m 58s		branch-3.3 passed
+1 💚	compile	20m 38s		branch-3.3 passed
+1 💚	checkstyle	1m 12s		branch-3.3 passed
+1 💚	mvnsite	2m 1s		branch-3.3 passed
+1 💚	javadoc	1m 8s		branch-3.3 passed
+1 💚	spotbugs	3m 19s		branch-3.3 passed
+1 💚	shadedclient	29m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 20s		the patch passed
+1 💚	compile	22m 39s		the patch passed
+1 💚	javac	22m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 7s		the patch passed
+1 💚	mvnsite	1m 52s		the patch passed
+1 💚	javadoc	0m 53s		the patch passed
+1 💚	spotbugs	3m 4s		the patch passed
+1 💚	shadedclient	28m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	18m 4s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	1m 10s		The patch does not generate ASF License warnings.
		187m 16s

Reason	Tests
Failed junit tests	hadoop.security.TestRaceWhenRelogin

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/2/artifact/out/Dockerfile
GITHUB PR	#4896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux d904c7693307 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `2260020`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/2/testReport/
Max. process+thread count	3098 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

mehakmeet · 2022-09-20T09:31:09Z

Test failure looks unrelated but happened after rebase, can you please push an empty commit to re-trigger the yetus once?

hadoop-yetus · 2022-09-20T16:17:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	37m 45s		branch-3.3 passed
+1 💚	compile	18m 52s		branch-3.3 passed
+1 💚	checkstyle	1m 27s		branch-3.3 passed
+1 💚	mvnsite	1m 53s		branch-3.3 passed
+1 💚	javadoc	1m 10s		branch-3.3 passed
+1 💚	spotbugs	2m 57s		branch-3.3 passed
+1 💚	shadedclient	27m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s		the patch passed
+1 💚	compile	18m 55s		the patch passed
+1 💚	javac	18m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 54s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed
+1 💚	spotbugs	3m 4s		the patch passed
+1 💚	shadedclient	27m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 24s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 22s		The patch does not generate ASF License warnings.
		165m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/4/artifact/out/Dockerfile
GITHUB PR	#4896
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux efcc147b04c1 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `24f7a62`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/4/testReport/
Max. process+thread count	1359 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4896/4/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hotcodemacha · 2022-09-21T05:03:09Z

@mehakmeet - We have a happy Yetus now :)

mehakmeet

+1

HADOOP-16769. LocalDirAllocator to provide diagnostics when file crea…

dc33468

…tion fails (apache#4842) The patch provides detailed diagnostics of file creation failure in LocalDirAllocator. Contributed by: Ashutosh Gupta

hotcodemacha mentioned this pull request Sep 16, 2022

HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4842

Merged

4 tasks

hotcodemacha force-pushed the branch-3.3 branch from 2260020 to dc33468 Compare September 20, 2022 13:28

Trigger Build

24f7a62

apache deleted a comment from hadoop-yetus Sep 21, 2022

mehakmeet approved these changes Sep 21, 2022

View reviewed changes

mehakmeet merged commit 683fa26 into apache:branch-3.3 Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4896

HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4896

Uh oh!

hotcodemacha commented Sep 16, 2022 •

edited

Loading

Uh oh!

hotcodemacha commented Sep 16, 2022

Uh oh!

hadoop-yetus commented Sep 16, 2022

Uh oh!

hotcodemacha commented Sep 20, 2022

Uh oh!

hadoop-yetus commented Sep 20, 2022

Uh oh!

mehakmeet commented Sep 20, 2022

Uh oh!

hadoop-yetus commented Sep 20, 2022

Uh oh!

hotcodemacha commented Sep 21, 2022

Uh oh!

mehakmeet left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4896

HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails #4896

Uh oh!

Conversation

hotcodemacha commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hotcodemacha commented Sep 16, 2022

Uh oh!

hadoop-yetus commented Sep 16, 2022

Uh oh!

hotcodemacha commented Sep 20, 2022

Uh oh!

hadoop-yetus commented Sep 20, 2022

Uh oh!

mehakmeet commented Sep 20, 2022

Uh oh!

hadoop-yetus commented Sep 20, 2022

Uh oh!

hotcodemacha commented Sep 21, 2022

Uh oh!

mehakmeet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hotcodemacha commented Sep 16, 2022 •

edited

Loading