-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17344. Last packet will be splited into two parts when write block. #6478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
9f0d15c to
528c72b
Compare
|
💔 -1 overall
This message was automatically generated. |
528c72b to
af5ddbc
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
c80db3b to
849b43d
Compare
|
@Hexiaoqiao @zhangshuyan0 Sir, please help review this PR when you have free time, Thanks a lot. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
58135bc to
8e9afe5
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
Refer to HDFS-17344.
As mentioned in #6368 (comment)
This PR is trying to solve this problem.
The root problem is that we pass inaccurate packet size(parameter psize) to computePacketChunkSize method within method adjustChunkBoundary.
How To Test
The existed unit test case testFirstPacketSizeInNewBlocks() can cover this PR's change.